Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6178] CORE Project summary edit mode bugs #3277

Merged
merged 7 commits into from
Oct 23, 2024
Merged

[MDS-6178] CORE Project summary edit mode bugs #3277

merged 7 commits into from
Oct 23, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Oct 22, 2024

Objective

  • bug bash on CORE project summary form edit mode
  • applied the text wrap fix to MS though while I was at it
  • and make the "help" ? button look a bit prettier on both (use the font awesome icon, couple of css rules)

MDS-6178

Why are you making this change? Provide a short explanation and/or screenshots

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
51.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@Jsyro Jsyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@taraepp taraepp merged commit a29e139 into develop Oct 23, 2024
18 of 19 checks passed
@taraepp taraepp deleted the mds-6178 branch October 23, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants